Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mk/rational arithmetic #141

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

kalmarek
Copy link

@kalmarek kalmarek commented Feb 6, 2022

No description provided.

@kalmarek
Copy link
Author

kalmarek commented Feb 6, 2022

oh, fuck; I had old version of MA in dev ;/

@odow
Copy link
Member

odow commented Feb 6, 2022

:( This is my fault sorry. I thought it was safe to clean things up because there were no open PRs!

@odow odow added this to the v1.x milestone Feb 7, 2022
@kalmarek
Copy link
Author

kalmarek commented Feb 7, 2022

ok, this looks ready from my side;

notable change:

  • use of Base.promote_op in promote_operation_fallback first and only when it fails fallback on construction of elts from their types

unfortunately I'm seeing quite some of

scalar_uniform_scaling: Test Failed at /home/kalmar/.julia/dev/MutableArithmetics/src/Test/generic.jl:6
  Expression: MA.isequal_canonical(#= /home/kalmar/.julia/dev/MutableArithmetics/src/Test/generic.jl:6 =# MA.@rewrite((x + 1) + I), (x + 1) + I)

in @rewrite with Rational{BigInt} test @blegat could you have a look?

@hersle
Copy link
Contributor

hersle commented Mar 7, 2024

Hi. Is there any update on merging this? Better division support would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants